Skip to content

Conversation

@fwilliams
Copy link
Collaborator

These parameters control the falloff curve for noise added to each Gaussian during optimization as a function of scale and opacity (more opaque Gaussians are considered more certain and undergo smaller perturbation during optimization). This PR doesn't change the default values of these but exposes them so they can be tuned as hyperparameters.

Signed-off-by: Francis Williams <francis@fwilliams.info>
@fwilliams fwilliams requested a review from a team as a code owner January 5, 2026 16:24
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Copy link
Contributor

@matthewdcong matthewdcong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine for the most part, but should we rename the variables to something more descriptive other than t and k?

@fwilliams
Copy link
Collaborator Author

It looks fine for the most part, but should we rename the variables to something more descriptive other than t and k?

I am not sure what to name these variables. It would end up being something verbose but not necessarily helpful (like noise_sigmoid_falloff_rate and noise_sigmoid_falloff_point neither of which are that helpful imo). The current names match those in eq.8 from the paper, which means you can refer back to that to see what they are. I can make the docs reflect this more clearly.

I don't expect these variables to be something a regular user would interact with. It's more for us to be able to tune default settings without having to recompile the code.

@matthewdcong
Copy link
Contributor

OK, if it's mostly for developer use then we can just keep it as is for now. The comments outline the usage and are probably sufficient for dev purposes.

@fwilliams fwilliams merged commit 4ed380f into openvdb:main Jan 6, 2026
32 checks passed
@fwilliams fwilliams deleted the fw/expose_kt branch January 6, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants