Update nanovdb to version 32.9.0 and refine grid type checks#475
Merged
swahtz merged 2 commits intoopenvdb:mainfrom Feb 24, 2026
Merged
Update nanovdb to version 32.9.0 and refine grid type checks#475swahtz merged 2 commits intoopenvdb:mainfrom
swahtz merged 2 commits intoopenvdb:mainfrom
Conversation
- Updated the nanovdb package to a newer commit (cfba6dff) for improved features and stability. - Refined grid type checks in `GridBatchImpl` and related functions to only support `ValueOnIndex` grids, simplifying the validation logic. - Removed references to `ValueOnIndexMask` in documentation and assertions to align with the new grid type restrictions. - Cleaned up unused code related to `ValueOnIndexMask` in `ActiveVoxelIterator.h` to reduce complexity. Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
fwilliams
approved these changes
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the NanoVDB library from version 32.8.0 to 32.9.0 and removes support for IndexMask and OnIndexMask grid types that have been deprecated in the newer version. The changes simplify the codebase by restricting support to only ValueOnIndex grids.
Changes:
- Updated NanoVDB commit hash in CMake configuration to version 32.9.0
- Removed template specialization for
ValueOnIndexMaskinActiveVoxelIterator.h - Simplified grid type validation and removed mask-related handling throughout the loading and grid batch implementation code
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cmake/get_nanovdb.cmake | Updates the NanoVDB git tag from version 32.8.0 to 32.9.0 |
| src/fvdb/detail/utils/nanovdb/ActiveVoxelIterator.h | Removes template specialization for deprecated ValueOnIndexMask type |
| src/fvdb/detail/io/LoadNanovdb.cpp | Removes support for IndexMask and OnIndexMask grid types, simplifies static assertions, removes mutability checks, and updates documentation to reflect ValueOnIndex-only support |
| src/fvdb/detail/GridBatchImpl.cu | Simplifies grid type validation to only accept ValueOnIndex grids |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We hadn't updated the NanoVDB commit since September, this updates the NanoVDB commit and makes the appropriate changes for the removal of IndexMask and OnIndexMask.
GridBatchImpland related functions to only supportValueOnIndexgrids, simplifying the validation logic.ValueOnIndexMaskin documentation and assertions to align with the new grid type restrictions.ValueOnIndexMaskinActiveVoxelIterator.hto reduce complexity.