Remove vestigial setup.py and GitLab CI config#570
Open
swahtz wants to merge 1 commit intoopenvdb:mainfrom
Open
Remove vestigial setup.py and GitLab CI config#570swahtz wants to merge 1 commit intoopenvdb:mainfrom
setup.py and GitLab CI config#570swahtz wants to merge 1 commit intoopenvdb:mainfrom
Conversation
The build system was migrated to scikit-build-core + pyproject.toml but the old scikit-build setup.py and the GitLab CI pipeline that depended on it were never cleaned up. Remove both files and update the remaining references: - Fix _is_editable_install() to check pyproject.toml instead of setup.py - Update src/tests/README.md build instructions to use ./build.sh - Remove stale _skbuild/ entries from docker-compose.yml and .dockerignore Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build system was migrated to scikit-build-core + pyproject.toml but the old scikit-build setup.py and the GitLab CI pipeline that depended on it were never cleaned up. Remove both files and update the remaining references: