fix bugs in COLMAP images text loading #177
Merged
+32
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMorven
requested review from
phapalova and
swahtz
and removed request for
a team
|
|
NotMorven
force-pushed
the
fix_bugs_load_colmap_images_txt
branch
from
f32e0e4 to
0347f24
Compare
Contributor
Author
|
@fwilliams @harrism So this PR is not welcome. I see... |
Collaborator
|
@NotMorven sorry we've been off for the holidays. You have some style check failures. Once those are fixed, I'll approve and we can merge |
Contributor
|
@NotMorven we value your contribution. Can you run |
NotMorven
force-pushed
the
fix_bugs_load_colmap_images_txt
branch
from
0347f24 to
923159a
Compare
Contributor
Author
|
@harrism @fwilliams Thanks for the reply. I've run |
Signed-off-by: NotMorven <[email protected]>
NotMorven
force-pushed
the
fix_bugs_load_colmap_images_txt
branch
from
923159a to
4b59b53
Compare
Contributor
Author
nice! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the _load_images_txt function in the main branch cannot handle cases where images have empty feature points. This results in subsequent image information failing to load properly. This PR resolves this issue.