Skip to content

Commit 97e0442

Browse files
committed
remove unused code
1 parent c233aa3 commit 97e0442

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

tests/test_zeep_transport.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,12 @@ def create_mock_session(timeout=None):
1515
mock_session = Mock(spec=aiohttp.ClientSession)
1616
if timeout:
1717
mock_session.timeout = timeout
18+
mock_session._timeout = timeout # Some code accesses private attribute
1819
else:
1920
# Create a default timeout object
20-
mock_session.timeout = Mock(total=300, sock_read=None)
21+
default_timeout = Mock(total=300, sock_read=None)
22+
mock_session.timeout = default_timeout
23+
mock_session._timeout = default_timeout # Some code accesses private attribute
2124
return mock_session
2225

2326

@@ -503,8 +506,8 @@ async def test_inherited_transport_attributes():
503506

504507

505508
@pytest.mark.asyncio
506-
async def test_no_session_auto_creates():
507-
"""Test transport auto-manages session if not provided."""
509+
async def test_session_reuse():
510+
"""Test transport reuses provided session."""
508511
mock_session = create_mock_session()
509512
transport = AIOHTTPTransport(session=mock_session)
510513

@@ -517,20 +520,17 @@ async def test_no_session_auto_creates():
517520
mock_aiohttp_response.raise_for_status = Mock()
518521
mock_aiohttp_response.read = AsyncMock(return_value=b"test")
519522

520-
# Without explicit session, should auto-create and cleanup
521-
with patch("onvif.zeep_aiohttp.ClientSession") as mock_session_class:
522-
mock_session = Mock(spec=aiohttp.ClientSession)
523-
mock_session.get = AsyncMock(return_value=mock_aiohttp_response)
524-
mock_session.close = AsyncMock()
525-
mock_session_class.return_value = mock_session
523+
mock_session.get = AsyncMock(return_value=mock_aiohttp_response)
524+
525+
# Make multiple requests
526+
result1 = await transport.get("http://example.com")
527+
result2 = await transport.get("http://example.com")
526528

527-
# Should work without explicit context manager
528-
result = await transport.get("http://example.com")
529-
assert result.content == b"test"
529+
assert result1.content == b"test"
530+
assert result2.content == b"test"
530531

531-
# Session should have been created and closed
532-
mock_session_class.assert_called()
533-
mock_session.close.assert_called()
532+
# Session should be reused
533+
assert mock_session.get.call_count == 2
534534

535535

536536
def test_sync_load_creates_new_loop():

0 commit comments

Comments
 (0)