Added support for Natted IP addresses #167
Open
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for natted ip addresses where previously onvif only worked when in local address. Instead of returning the local IP address, it returns the same IP/port used to create the ONVIFCamera object
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for natted ip addresses where previously onvif only worked when in local address.
Instead of returning the local IP address, it returns the same IP/port used to create the ONVIFCamera object
This solves #82
If anything else is needed please let me know.
This is something I required for frigate, and my fork currently works great for both frigate and homeassistant integration.