chore: Change logger name to 'PyViCare...'#738
Conversation
|
@CFenner Quick question: the library uses If |
|
Alternatively, I could switch to |
|
I think it is intentional as it matches the integration name. Actually I have no idea what the manifest entry is for. |
|
The I confirmed this on our system: with debug enabled, zero We could fix it on the HA side (change manifest to |
|
Ah, Sorry thought this is the HA repo 🙄 would be nice if you could switch to the more meaningful name. |
All modules used logging.getLogger('ViCare') which doesn't match the
package name and prevents HA's manifest loggers field from capturing
library debug output. Switch to __name__ for standard Python per-module
logging (e.g. PyViCare.PyViCareService, PyViCare.PyViCareCachedService).
|
Updated to use |
All 7 modules use
logging.getLogger('ViCare'), but Home Assistant's vicare integration registers"loggers": ["PyViCare"]in itsmanifest.json. This mismatch means HA's logger configuration for the integration has no effect on the library's log output.Renaming to
'PyViCare'matches the package name (Python convention) and makes HA's logger settings work as expected.