[WC] GroupSizeFallbackMode instead of enable_flexible_group_size #3583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-savelyevv
changed the title
GroupSizeFallbackMode instead of enable_flexible_group_size
Collaborator
Author
|
Need some time to clarify the IGNORE case |
nikita-savelyevv
force-pushed
the
ns/flexible-group-size-pt2
branch
from
e82a7e5 to
dbe0a76
Compare
Collaborator
Author
Done |
ljaljushkin
requested changes
Jul 14, 2025
src/nncf/quantization/algorithms/weight_compression/algorithm.py
Outdated
Show resolved
Hide resolved
src/nncf/quantization/algorithms/weight_compression/algorithm.py
Outdated
Show resolved
Hide resolved
ljaljushkin
approved these changes
Jul 14, 2025
andreyanufr
approved these changes
Jul 15, 2025
alexsu52
approved these changes
Jul 15, 2025
alexsu52
pushed a commit
that referenced
this pull request
Jul 16, 2025
### Changes Follow up to #3583. Decided to tweak a log message a little bit.
nikita-savelyevv
pushed a commit
to AlexanderDokuchaev/nncf
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
enable_flexible_group_sizewith agroup_size_fallback_modeenum. Possible values are NONE, IGNORE, ADJUST. Meaning:enable_flexible_group_size=Trueon develop, i.e. compute new group size if possible, otherwise compress to backup precision.min_flexible_group_sizetomin_adjusted_group_size.Set
group_size_fallback_modeto IGNORE by default.Users are informed the following way depending on the selected fallback mode:
group_size_fallback_modeto IGNORE or ADJUST.Reason for changes
UX improvement: now the default behavior won't result in an exception.
Related tickets
167337
Tests
Adopted the tests introduced in #3556.