-
Notifications
You must be signed in to change notification settings - Fork 259
[Torch FX] Compress PT2E Support #3663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
anzr299
wants to merge
55
commits into
openvinotoolkit:develop
Choose a base branch
from
anzr299:an/fx/compress_pt2e
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,994
−60
Draft
Changes from 48 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
190f9d5
init
anzr299 c52fcca
fixes
anzr299 4e56cb5
add message for unsupported external quantizers
anzr299 9651ceb
add algorithm
anzr299 14daeb5
impotr openvino quantizer from nncf instead of executorch
anzr299 3746815
Add observers and openvino quantizer to nncf
anzr299 0815dc5
fix
anzr299 1b8d940
minor fix
anzr299 7d35374
fix
anzr299 427ebc2
fix some more bugs; observers was importing from torchao. causing mis…
anzr299 24dbfb6
add compress pt2e to init
anzr299 4bb8c1a
fix quantizer init file. Remove extra code.
anzr299 8902842
small fix for the big problem:)
anzr299 3842538
fix quantizer preset definition
anzr299 2e70c2e
fix openvino quantizer for ptq. call _algo instead of legacy _min_max…
anzr299 b1c9aad
fix quantizer defaults
anzr299 33fe01c
microfix
anzr299 d8e1006
precommit fix
anzr299 88a8472
revert openvino quantizer to old
anzr299 7a8e51a
create ovquantizer in executorch dir
anzr299 fed5052
update executorch quantizer location.
anzr299 2866473
check if openvino quantizer has weight compression in openvino adapter
anzr299 7171d56
review comments
anzr299 3e3b067
revert ignored scope changes; make sensitivity metric None to check i…
anzr299 5b7b210
precommit fix
anzr299 71a479f
pre commit format
anzr299 b24a59c
rename executorch quantizer to test_quantizer
anzr299 d12225a
fix last precommit
anzr299 9870ee2
remove unused mypy ignore
anzr299 8015629
get the mode as struct
anzr299 0804218
fix algorithm
anzr299 1f1fda3
remove quantizer and observers from nncf. Instead import from executorch
anzr299 623ce46
rework wc algorithm so that get_weight_comrpession_params becomes mor…
anzr299 d14a6eb
fix bugs; use sensitivity metric instead of mixed precision algo
anzr299 e91b455
update algorithm with new reworking
anzr299 448bf84
changes
anzr299 8e23572
review changes
anzr299 36ddf53
change WeightsCompressionPT2E to ExperimentalWeightsCompression
anzr299 07b730b
change ExperimentalWeightsCompression to WeightsCompression
anzr299 d5dd422
add comments
anzr299 076a76b
add typehints
anzr299 2ce9eec
add docstrings
anzr299 1bebf3e
add typehint for quantize pt2e
anzr299 ea81cfd
Merge branch 'openvinotoolkit:develop' into an/fx/compress_pt2e
anzr299 e82920f
return original develop branch changes
anzr299 82cc10b
update typehints and docs
anzr299 beae508
format
anzr299 8bd95df
update type hinting of openvino adapter
anzr299 aac9d3f
add test
anzr299 4278cfd
update reference graphs; use more samples for calibration dataset. Th…
anzr299 6fd5216
remove groupsize values as return statement from get_weight_compressi…
anzr299 118b611
update algorithm
anzr299 e9f3cd4
change WeightCompression to OriginalWeightCompression in experimental…
anzr299 a969e58
update docstrings as discussed offline
anzr299 71d0597
revert torchaoadapter code
anzr299 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
src/nncf/experimental/quantization/algorithms/weight_compression/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Copyright (c) 2025 Intel Corporation | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. |
138 changes: 138 additions & 0 deletions
138
src/nncf/experimental/quantization/algorithms/weight_compression/algorithm.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,138 @@ | ||
# Copyright (c) 2025 Intel Corporation | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from typing import Iterable, Optional | ||
|
||
import torch | ||
|
||
import nncf | ||
from nncf import AdvancedCompressionParameters | ||
from nncf import CompressionFormat | ||
from nncf import Dataset | ||
from nncf import SensitivityMetric | ||
from nncf.common.graph.graph import NNCFGraph | ||
from nncf.common.graph.graph import NNCFNode | ||
from nncf.common.tensor_statistics.statistic_point import StatisticPointsContainer | ||
from nncf.common.utils.backend import BackendType | ||
from nncf.experimental.quantization.quantizer import Quantizer | ||
from nncf.quantization.algorithms.algorithm import Algorithm | ||
from nncf.quantization.algorithms.weight_compression.algorithm import WeightCompression | ||
|
||
|
||
class WeightsCompression(Algorithm): | ||
""" | ||
Post-training Weight Compression algorithm implementation. | ||
|
||
Compresses weights of Linear and Embedding layers to 8-bit integer or | ||
to 4-bit integer/float depending on mode, ratio and group size. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
quantizer: Quantizer, | ||
subset_size: int = 128, | ||
awq: bool = False, | ||
scale_estimation: bool = False, | ||
gptq: bool = False, | ||
lora_correction: bool = False, | ||
sensitivity_metric: SensitivityMetric = SensitivityMetric.WEIGHT_QUANTIZATION_ERROR, | ||
compression_format: CompressionFormat = CompressionFormat.DQ, | ||
advanced_parameters: AdvancedCompressionParameters = None, | ||
) -> torch.fx.GraphModule: | ||
""" | ||
:param quantizer: Quantizer to use in WeightCompression algorithm. | ||
:param subset_size: Number of data samples to calculate activation statistics used for assigning different | ||
quantization precision. | ||
:param awq: determines whether to use or not modified AWQ algorithm. | ||
:param scale_estimation: determines whether to use or not scale estimation for 4 bit layers. | ||
:param gptq: determines whether to use or not GPTQ algorithm. | ||
:param lora_correction: determines whether to use or not LoRA Correction algorithm. | ||
:param sensitivity_metric: The sensitivity metric for assigning quantization precision to layers. In order to | ||
preserve the accuracy of the model, the more sensitive layers receives a higher precision. | ||
:param compression_format: Describes the format in which the model is saved after weight compression. | ||
:param advanced_parameters: advanced parameters for algorithms in compression pipeline. | ||
""" | ||
self._quantizer = quantizer | ||
|
||
wc_config = self._quantizer.get_weight_compression_config() | ||
|
||
self._mode = wc_config.get("mode", None) | ||
self._awq = awq | ||
self._gptq = gptq | ||
self._scale_estimation = scale_estimation | ||
self._subset_size = subset_size | ||
self._advanced_parameters = advanced_parameters | ||
self._lora_correction = lora_correction | ||
self._ratio = wc_config.get("ratio", 1) | ||
self._group_size = wc_config.get("group_size", 128) | ||
self._all_layers = wc_config.get("all_layers", False) | ||
self._backup_mode = wc_config.get("backup_mode", nncf.BackupMode.INT8_ASYM) | ||
self._sensitivity_metric = sensitivity_metric | ||
self._compression_format = compression_format | ||
self._algo = WeightCompression( | ||
mode=self._mode, | ||
ratio=self._ratio, | ||
group_size=self._group_size, | ||
ignored_scope=nncf.IgnoredScope(), # This is already defined in the quantizer object | ||
all_layers=self._all_layers, | ||
sensitivity_metric=self._sensitivity_metric, | ||
awq=self._awq, | ||
subset_size=self._subset_size, | ||
scale_estimation=self._scale_estimation, | ||
gptq=self._gptq, | ||
lora_correction=self._lora_correction, | ||
backup_mode=self._backup_mode, | ||
compression_format=self._compression_format, | ||
advanced_parameters=self._advanced_parameters, | ||
) | ||
|
||
def available_backends(self) -> list[BackendType]: | ||
return self._algo.available_backends() | ||
|
||
def apply( | ||
self, | ||
model: torch.fx.GraphModule, | ||
graph: NNCFGraph, | ||
statistic_points: Optional[StatisticPointsContainer] = None, | ||
dataset: Optional[Dataset] = None, | ||
) -> torch.fx.GraphModule: | ||
self._algo.set_backend_entity(model) | ||
|
||
all_weight_params, ratio_defining_params, group_size_values, skipped_weight_params = ( | ||
self._quantizer.get_weight_compression_parameters(model, graph) | ||
) | ||
|
||
return self._algo.apply_with_parameters( | ||
model, | ||
graph, | ||
dataset, | ||
statistic_points, | ||
all_weight_params, | ||
ratio_defining_params, | ||
group_size_values, | ||
skipped_weight_params, | ||
) | ||
|
||
def get_statistic_points( | ||
self, | ||
model: torch.fx.GraphModule, | ||
graph: NNCFGraph, | ||
nodes_and_port_ids: Iterable[tuple[NNCFNode, int]], | ||
) -> StatisticPointsContainer: | ||
""" | ||
Returns statistic points, for which StatisticsCollector should collect statistics. | ||
|
||
:param model: Model for statistics collection. | ||
:param graph: Model graph. | ||
:param nodes_and_port_ids: Nodes and port ids for which statistics should be collected. | ||
:return: Statistic points, for which StatisticsCollector should collect statistics. | ||
""" | ||
return self._algo.get_statistic_points(model, graph, nodes_and_port_ids) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, good catch! I will change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done