[Weight Compression] Rework Weight Comrpession Algorithm #3667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anzr299
force-pushed
the
an/rework_wc
branch
from
9653817 to
e7776f9
Compare
|
@anzr299, should we close this PR? |
Perhaps we can keep this as a reference for our later re-working of the WC algorithm |
|
Can we keep it as a local pr or branch? We usually don't keep draft PRs open to minimize number of open PRs. Please keep this branch and close this PR |
Ah okay, that sounds better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reworked the weight compression algorithm. Separated the apply method into distinct modular functions.
Reason for changes
To make it simpler for Experimental compress_pt2e algorithms and offer some flexibility in obtaining information such as nodes_to_compress, weight compression parameters etc. from sources outside the scope of Weight Compression algorithm.