Support models without a batch dimension#3721
Open
Thakor-Yashpal wants to merge 2 commits intoopenvinotoolkit:developfrom
Open
Support models without a batch dimension#3721Thakor-Yashpal wants to merge 2 commits intoopenvinotoolkit:developfrom
Thakor-Yashpal wants to merge 2 commits intoopenvinotoolkit:developfrom
Conversation
Collaborator
|
@daniil-lyakhov , please take a look |
daniil-lyakhov
requested changes
Nov 5, 2025
Collaborator
daniil-lyakhov
left a comment
daniil-lyakhov
left a comment
There was a problem hiding this comment.
@Thakor-Yashpal, thank you for the contribution! Please apply the comments and add the test reproducer to the PR
.gitignore
Outdated
| .installed.cfg | ||
| *.egg | ||
|
|
||
| my_project_env |
Collaborator
There was a problem hiding this comment.
Suggested change
| my_project_env |
src/nncf/version.py
Outdated
| # limitations under the License. | ||
|
|
||
| __version__ = "2.19.0" | ||
| __version__ = "2.19.0.dev0+1489448a3dirty" |
Collaborator
There was a problem hiding this comment.
Suggested change
| __version__ = "2.19.0.dev0+1489448a3dirty" | |
| __version__ = "2.19.0" |
Comment on lines
+129
to
+132
| # Copyright (c) 2025 Intel Corporation | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at |
Collaborator
There was a problem hiding this comment.
Looks like some issues with the code merging, there are two different classes with the same name in the PR
github-actions
bot
added
the
NNCF OpenVINO
Collaborator
|
@Thakor-Yashpal , do you have any update with this PR? Do you plan to finalize it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
nncf/quantization/algorithms/fast_bias_correction/openvino_backend.py.create_input_datamethod to add a specific check for 1D input shapes (i.e.,len(shape) == 1).datalist.Reason for changes
The
create_input_datamethod was looping based on the channel dimension size (3) but should have been based on the statistics list size (1)Related tickets
Closes the feature request: "Currently FastBiasCorrection algorithm does not support models without the batch dimension"
#3481
Tests
Verified the fix by running the reproducer command provided in the issue, which now passes: