Skip to content

Conversation

@daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Jan 8, 2026

Changes

  • Legacy unused code is removed
  • Legacy NNCFTensor is removed
  • get_raw_stat_collector moved to common file src/nncf/common/tensor_statistics/builders.py
  • get_mean_stat_collector moved to common file src/nncf/common/tensor_statistics/builders.py for ONNX/Torch
  • get_mean_stat_collector moved to a file src/nncf/openvino/statistics/builders.py for OpenVINO

Reason for changes

To remove unused code and better format the repo

@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner January 8, 2026 16:31
@daniil-lyakhov daniil-lyakhov changed the title Legacy unused torch aggregator is removed [Torch] Legacy unused aggregator is removed Jan 8, 2026
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Jan 8, 2026
@daniil-lyakhov daniil-lyakhov marked this pull request as draft January 8, 2026 16:36
@daniil-lyakhov daniil-lyakhov changed the title [Torch] Legacy unused aggregator is removed [Torch] Legacy unused statistics code is removed Jan 8, 2026
@github-actions github-actions bot added NNCF Common Pull request that updates NNCF Common API Public API-impacting changes labels Jan 8, 2026
@daniil-lyakhov daniil-lyakhov changed the title [Torch] Legacy unused statistics code is removed Legacy unused code is removed Jan 12, 2026
@daniil-lyakhov daniil-lyakhov force-pushed the dl/remove_torch_aggr branch 2 times, most recently from 1a2c7e2 to 2c7e433 Compare January 12, 2026 15:21
@github-actions github-actions bot added the NNCF OpenVINO Pull requests that updates NNCF OpenVINO label Jan 12, 2026
@daniil-lyakhov daniil-lyakhov force-pushed the dl/remove_torch_aggr branch 2 times, most recently from 777348e to efeacb3 Compare January 12, 2026 15:49
@daniil-lyakhov daniil-lyakhov marked this pull request as ready for review January 12, 2026 16:15
@@ -18,12 +18,13 @@
from nncf.common.tensor_statistics.collectors import RawReducer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buiders.py, done

@@ -0,0 +1,52 @@
# Copyright (c) 2026 Intel Corporation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buiders.py, done


class PTInitializingDataLoader(NNCFDataLoader):
"""
THIS CLASS IS ONLY USED IN THE Optimum-Intel REPO AND
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add #TODO comment about it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AlexanderDokuchaev AlexanderDokuchaev self-requested a review January 13, 2026 12:02
daniil-lyakhov and others added 2 commits January 13, 2026 14:36
Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
@daniil-lyakhov
Copy link
Collaborator Author

@AlexanderDokuchaev, please merge if no comments

@AlexanderDokuchaev AlexanderDokuchaev merged commit 68030ca into openvinotoolkit:develop Jan 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Public API-impacting changes NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants