Add Adaptive R-KV reference op implementation #32299
Open
+658
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshampor
force-pushed
the
adaptive_rkv_reference
branch
2 times, most recently
from
6581f58 to
370153b
Compare
vshampor
force-pushed
the
adaptive_rkv_reference
branch
from
664b7d6 to
4401b8c
Compare
vshampor
force-pushed
the
adaptive_rkv_reference
branch
from
4401b8c to
4de52d3
Compare
l-bat
reviewed
Oct 8, 2025
src/core/reference/include/openvino/reference/adaptive_rkv_diversity.hpp
Outdated
Show resolved
Hide resolved
src/core/reference/include/openvino/reference/adaptive_rkv_diversity.hpp
Outdated
Show resolved
Hide resolved
src/core/reference/include/openvino/reference/adaptive_rkv_diversity.hpp
Show resolved
Hide resolved
Comment on lines
+216
to
+213
| std::shared_ptr<T[]> allocate_buf(const Shape& shape) { | ||
| return std::shared_ptr<T[]>(new T[ov::shape_size(shape)]); | ||
| } |
There was a problem hiding this comment.
Can std::shared_ptr<T[]> be replaced with std::vector<T> to simplify the code?
There was a problem hiding this comment.
Probably, but I wouldn't say that this simplifies the code. I could probably use std::vector<T>::clear instead of std::shared_ptr<T[]>::reset to release memory of unneeded buffers, but I would also need to use shrink_to_fit afterwards, which is by the way not guaranteed to release memory at all.
src/core/reference/include/openvino/reference/adaptive_rkv_diversity.hpp
Outdated
Show resolved
Hide resolved
src/core/reference/include/openvino/reference/adaptive_rkv_diversity.hpp
Outdated
Show resolved
Hide resolved
src/core/reference/include/openvino/reference/adaptive_rkv_diversity.hpp
Outdated
Show resolved
Hide resolved
vshampor
force-pushed
the
adaptive_rkv_reference
branch
from
cd1c053 to
223b2d4
Compare
l-bat
approved these changes
Oct 9, 2025
vshampor
force-pushed
the
adaptive_rkv_reference
branch
from
223b2d4 to
ef12386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: 173520