[GHA] Switch code style checks to use Docker environment #32342
+173
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: CI
…-use-Docker-environment
…-use-Docker-environment
…-use-Docker-environment
…-use-Docker-environment
…-use-Docker-environment
…-use-Docker-environment
…-use-Docker-environment
…-use-Docker-environment
akashchi
approved these changes
Oct 17, 2025
akladiev
reviewed
Oct 17, 2025
| python3 get-pip.py --no-cache-dir pip==${PIP_VERSION} && \ | ||
| rm -f get-pip.py | ||
|
|
||
| ADD cmake/developer_package/ncc_naming_style/requirements_dev.txt /requirements_dev.txt |
There was a problem hiding this comment.
Generally we install Python requirements in runtime (since we need to ensure the freshest state of requirements, including those that don't include direct requirement file change, e.g. when a new version of a non-pinned module is released on PyPi). If we're installing it inside the docker - only direct file change will cause image rebuild, which is not enough
There was a problem hiding this comment.
why do we need this step then?
mryzhov
reviewed
Oct 17, 2025
| image: ${{ fromJSON(needs.docker.outputs.images).ov_test.ubuntu_24_04_x64_code_style }} | ||
| volumes: | ||
| - /mount:/mount | ||
| options: --user 1001 # We use standard github-actions user inside container to avoid permission issues after checkout |
There was a problem hiding this comment.
Can we move it inside the docker image configuration?
mryzhov
reviewed
Oct 17, 2025
| runs-on: ubuntu-22.04 | ||
| if: ${{ github.repository_owner == 'openvinotoolkit' }} | ||
| needs: Docker | ||
| runs-on: aks-linux-4-cores-16gb |
There was a problem hiding this comment.
Why not the medium runner?
mryzhov
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets: