-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[CPU]Coverity scan issues #32343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU]Coverity scan issues #32343
Conversation
3e08272
to
f8060cf
Compare
@maxnick, could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses Coverity scan issues by fixing potential null pointer dereferences, integer overflow, and removing dead code to improve code safety and quality.
- Added bounds checking and null pointer validation through OPENVINO_ASSERT statements
- Removed unused computation and dead code to eliminate unnecessary operations
- Fixed loop bounds to prevent potential integer overflow conditions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/plugins/intel_cpu/src/shape_inference/static_shape.hpp | Added bounds checking for array access operator |
src/plugins/intel_cpu/src/shape_inference/custom/reshape.cpp | Removed unused computation that was redundant |
src/plugins/intel_cpu/src/nodes/tensoriterator.cpp | Added validation for loop body condition output index |
src/plugins/intel_cpu/src/nodes/strided_slice.cpp | Fixed loop bounds and added size validation |
src/plugins/intel_cpu/src/nodes/log_softmax.cpp | Added axis bounds validation |
src/plugins/intel_cpu/src/nodes/input.cpp | Added null pointer check for external memory descriptor |
src/plugins/intel_cpu/src/nodes/executors/dnnl/dnnl_convolution_primitive.cpp | Removed dead return statement |
src/plugins/intel_cpu/src/nodes/deconv.cpp | Added validation for DNNL compatible weights |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current changes LGTM just one minor comments in static_shape.hpp
.
and another question is: from Jaroslaw's comments in the ticket. it seems some fix not included in this pr: e.g.
/src/plugins/intel_cpu/src/nodes/fullyconnected.cpp
/src/plugins/intel_cpu/src/nodes/subgraph.cpp
/src/plugins/intel_cpu/src/nodes/color_convert.cpp
/src/plugins/intel_cpu/src/nodes/llm_mlp.cpp
I don't know whether because there's another step/plan for these left fix?
386555a
to
89b3df8
Compare
Others are false positive. |
c7cb066
to
2cf2b24
Compare
Details:
Tickets: