Add OpenVmHalo2Verifier #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed verifier contract to expose a more user-friendly interface
HrikB
force-pushed
the
feat/verifier-formatter
branch
from
5c7a107 to
0a6416e
Compare
HrikB
force-pushed
the
feat/verifier-formatter
branch
from
cd7ca2c to
5d3cd40
Compare
yi-sun
requested changes
Mar 20, 2025
Collaborator
Author
|
I'll wait on release tagging before merge |
yi-sun
requested changes
Mar 20, 2025
HrikB
force-pushed
the
feat/verifier-formatter
branch
from
f7e27ed to
41c44c4
Compare
HrikB
force-pushed
the
feat/verifier-formatter
branch
from
3f0d799 to
66dc440
Compare
yi-sun
reviewed
Mar 21, 2025
yi-sun
reviewed
Mar 21, 2025
yi-sun
reviewed
Mar 21, 2025
yi-sun
reviewed
Mar 21, 2025
yi-sun
approved these changes
Mar 21, 2025
Contributor
yi-sun
left a comment
yi-sun
left a comment
There was a problem hiding this comment.
LGTM, but please rename all instances of guest PVs
yi-sun
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
OpenVmHalo2Verifierthat exposes a more user-friendly interface to users of OpenVM.This SDK assumes that the public values reveal in the guest are exactly 32 bytes.
TODO:
Halo2Verifierwith the verifier a default OpenVM configuration.Add test for pvs size that is not a multiple of 32Closes INT-3597