[feat] cargo axiom e2e test #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INT-2857 CLI fixes and e2e test
|
Golovanov399
requested review from
jonathanpwang,
nyunyunyunyu and
stephenh-axiom-xyz
| pub fn read_exe_from_file<P: AsRef<Path>>(path: P) -> Result<AxVmExe<F>> { | ||
| read_from_file_bson(path) | ||
| let data = std::fs::read(path)?; | ||
| let exe = bincode::serde::decode_from_slice(&data, bincode::config::standard())?.0; |
Contributor
There was a problem hiding this comment.
I will look into if we can use one package (maybe bitcode) for everything. OK for now
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Add transpiler config read * Fix exe rw * Attempt at adding a workflow * Change the test so that it's now not a workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves INT-2857.
It is now able to read the transpiler from the app config toml (in order to do this, I changed the
(read|write)_exe_(from|to)_filefunctions so that the don't use any form of JSON since our maps have keys incompatible with json). Also, there is a cli e2e test now (runs on push to main (I hope) and whenrun-cli-e2elabel is on).Copilot:
This pull request introduces a new GitHub Actions workflow for end-to-end testing of the CLI and refactors several functions to improve file handling and transpiler configuration in the
axvm-sdkandcargo-axiomcrates. The most important changes are:New GitHub Actions Workflow:
.github/workflows/cli-e2e.yml: Added a new workflow for running end-to-end tests on the CLI, triggered by pushes to themainbranch and pull requests affecting specific paths. This includes setting up the environment, installing dependencies, and running the tests.Refactoring for File Handling:
crates/axvm-sdk/src/fs.rs: Refactored theread_exe_from_fileandwrite_exe_to_filefunctions to usebincodefor encoding and decoding, replacing the previous BSON-based implementations.Transpiler Configuration:
crates/cargo-axiom/src/commands/build.rs: Added support for specifying a transpiler configuration file via a new command-line argument--transpiler-config. This allows users to customize the transpiler extensions used during the build process. [1] [2]Code Cleanup:
crates/cargo-axiom/src/commands/build.rs: Removed the now redundanttranspilefunction and integrated its logic directly into thebuildfunction, streamlining the code.