Skip to content

feat: Add SHA-512 and SHA-384 support to the SHA-256 VM extension #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: Add SHA-512 and SHA-384 support to the SHA-256 VM extension #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
68630ef
Add ColsRef macro
Avaneesh-axiom Apr 7, 2025
399a393
Rename crates/circuits/sha256-air/ to crates/circuits/sha2-air/
Avaneesh-axiom Apr 7, 2025
c714d13
Update SHA-256 subair to support SHA-512 and SHA_384
Avaneesh-axiom Apr 7, 2025
a3b73ca
Rename extensions/sha256 to extensions/sha2
Avaneesh-axiom Apr 7, 2025
96b3e5c
Update SHA-256 VM chip to support SHA-512 and SHA-384
Avaneesh-axiom Apr 7, 2025
f38d801
Rename examples/sha256 to examples/sha2
Avaneesh-axiom Apr 7, 2025
49c739d
Update SHA-256 examples
Avaneesh-axiom Apr 7, 2025
e62ed2c
Rename SHA-256 to SHA-2 in various places
Avaneesh-axiom Apr 7, 2025
aaef884
Update the docs
Avaneesh-axiom Apr 7, 2025
05d78e4
Rename book/src/custom-extensions/sha256.md to sha2.md
Avaneesh-axiom Apr 7, 2025
1d4bd1f
Update book
Avaneesh-axiom Apr 7, 2025
665237e
Fix lint
Avaneesh-axiom Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/extension-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- { name: "rv32im", path: "rv32im" }
- { name: "native", path: "native" }
- { name: "keccak256", path: "keccak256" }
- { name: "sha256", path: "sha256" }
- { name: "sha2", path: "sha2" }
- { name: "bigint", path: "bigint" }
- { name: "algebra", path: "algebra" }
- { name: "ecc", path: "ecc" }
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/primitives.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
paths:
- "crates/circuits/primitives/**"
- "crates/circuits/poseidon2-air/**"
- "crates/circuits/sha256-air/**"
- "crates/circuits/sha2-air/**"
- "crates/circuits/mod-builder/**"
- "Cargo.toml"
- ".github/workflows/primitives.yml"
Expand Down Expand Up @@ -47,8 +47,8 @@ jobs:
run: |
cargo nextest run --cargo-profile fast --features parallel

- name: Run tests for sha256-air
working-directory: crates/circuits/sha256-air
- name: Run tests for sha2-air
working-directory: crates/circuits/sha2-air
run: |
cargo nextest run --cargo-profile fast --features parallel

Expand Down
Loading
Loading