Skip to content

Conversation

Schaeff
Copy link

@Schaeff Schaeff commented Oct 7, 2025

It is not required after a small refactor.

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 09:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Send + Sync trait bounds from the Executor type in the VmExecutionConfig trait. The change is made possible by refactoring the filtered_execution_frequencies method to use zip_eq and filter_map instead of enumerate and separate indexing, eliminating the need for thread-safety constraints on the executor type.

  • Removed Send + Sync bounds from VmExecutionConfig::Executor trait
  • Refactored filtered_execution_frequencies method to use iterator combinators instead of indexing
  • Simplified the filtering logic using filter_map and then_some

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/vm/src/arch/config.rs Removed Send + Sync trait bounds from the Executor associated type
crates/vm/src/arch/interpreter_preflight.rs Refactored method implementation to eliminate need for Send + Sync bounds and improved iterator usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

jonathanpwang

This comment was marked as outdated.

@jonathanpwang jonathanpwang changed the title Remove send + sync bound on executor chore: Remove send + sync bound on executor Oct 7, 2025
@jonathanpwang
Copy link
Contributor

@Schaeff there is some clippy/fmt issue

@jonathanpwang
Copy link
Contributor

The CI errors are something about zip_eq where the imports necessary differ with feature = "parallel" on or off

@jonathanpwang
Copy link
Contributor

@Schaeff please try to fix the CI issues again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants