Skip to content

fix: lazy_update_boundary_heights needs to handle uninitialized memory #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2025
Merged

fix: lazy_update_boundary_heights needs to handle uninitialized memory #2286

merged 3 commits into from
Nov 30, 2025

Conversation

@jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Nov 30, 2025 •
edited
Loading

towards INT-5617

The metering update did not account for the initial 8->4 split from handle_uninitialized_memory

Copilot AI review requested due to automatic review settings November 30, 2025 03:10
@jonathanpwang jonathanpwang force-pushed the fix/access-adapter-large-init branch from a1e4711 to 3a4b51f Compare November 30, 2025 03:10
Copilot finished reviewing on behalf of jonathanpwang November 30, 2025 03:11

This comment was marked as outdated.

Sign in to view

@jonathanpwang jonathanpwang force-pushed the fix/access-adapter-large-init branch from 3a4b51f to 8a3d757 Compare November 30, 2025 03:16
@github-actions

This comment has been minimized.

Sign in to view
nyunyunyunyu
nyunyunyunyu reviewed Nov 30, 2025
View reviewed changes
nyunyunyunyu

This comment was marked as resolved.

Sign in to view

@github-actions

This comment has been minimized.

Sign in to view
@jonathanpwang jonathanpwang force-pushed the fix/access-adapter-large-init branch from 42f0e0d to a35cd12 Compare November 30, 2025 18:11
@jonathanpwang jonathanpwang changed the title fix: lazy_update_boundary_heights needs to handle large initial accesses fix: lazy_update_boundary_heights needs to handle uninitialized memory Nov 30, 2025
@github-actions
Copy link

github-actions bot commented Nov 30, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-15 [-6.1%]) 232 322,610 2,058,654 - - -
fibonacci (+2 [+0.2%]) 1,001 1,500,209 2,100,402 - - -
regex (-45 [-1.9%]) 2,337 4,137,502 17,695,216 - - -
ecrecover (-54 [-7.1%]) 705 122,859 2,263,998 - - -
pairing (+52 [+3.7%]) 1,465 1,745,742 (-59908 [-0.2%]) 25,408,302 - - -

Commit: a35cd12

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit b0a4b89 into main Nov 30, 2025
80 of 89 checks passed
@jonathanpwang jonathanpwang deleted the fix/access-adapter-large-init branch November 30, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@shuklaayush shuklaayush shuklaayush approved these changes

@nyunyunyunyu nyunyunyunyu Awaiting requested review from nyunyunyunyu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanpwang @nyunyunyunyu @shuklaayush