-
Notifications
You must be signed in to change notification settings - Fork 84
fix(aot): x86 assembly for addr_space_access_count update
#2340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an x86-64 assembly bug in the AOT (ahead-of-time) compilation module for the RV32IM circuit. The bug incorrectly used a 32-bit memory operation (dword ptr) with a 4-byte stride when accessing elements of addr_space_access_count, which is actually an array of usize values (64-bit on x86-64 systems).
Key Changes:
- Corrected assembly instruction from
dword ptrwith* 4stride toqword ptrwith* 8stride to match the 64-bitusizeelement size
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nyunyunyunyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK but maybe it's better to use u32 instead of usize(which size is not constant)
This comment has been minimized.
This comment has been minimized.
CodSpeed Performance ReportMerging #2340 will not alter performanceComparing
|
This reverts commit 4208c0b.
switched to u32 |
Commit: 8398a0b |
found while reviewing previous PR