-
Notifications
You must be signed in to change notification settings - Fork 84
feat: add instruction count table to openvm-prof #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
|
Can you provide instructions (in this PR desc for now) on how to generate the metrics.json needed by openvm-prof? Provide explicit commands for one particular case to test. After it looks good, we can update the benchmark docs |
|
I've just updated the description with the instructions |
|
Can you remove the dsl_ir column and run it on an example with multiple segments (just a larger fibonacci program would do it)? Then give a top level table where the instruction counts are aggregated across all segments. Then more detailed per-segment instrumentation. |
|
@876pol can you fix the lint? Format on save is likely not being triggered because you need to install Rust nightly: |
This comment has been minimized.
This comment has been minimized.
Commit: cb26827 |
jonathanpwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you update the documentation for benchmarks to include a section on profiling detailed instruction count?
|
|
||
| let mut markdown_output = String::from_utf8(writer)?; | ||
|
|
||
| // TODO: calculate diffs for instruction count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we need this since these are more detailed metrics
Resolves INT-5845.
Only the metric post-processor is edited. To generate the
metrics.jsonwith the instruction count information, run with theperf-metricsfeature. For instance, to run thefibonaccitest and generate the instruction count table, runThe generated aggregated table for
fibonacci(forn=3000000) looks like:The detailed table with the breakdown by segment looks like: