perf: revisit varrangechecker#2401
Merged
Tuanlinh12312 merged 4 commits intodevelop-v2from Feb 11, 2026
Merged
Conversation
Tuanlinh12312
requested review from
jonathanpwang,
stephenh-axiom-xyz and
zlangley
branch-rebase-bot
bot
force-pushed
the
develop-v2
branch
from
a0ab899 to
61263de
Compare
Contributor
|
@Tuanlinh12312 please clean up this PR |
Tuanlinh12312
force-pushed
the
perf/revisit-varrangechecker
branch
from
efe9ccd to
1cabea1
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
branch-rebase-bot
bot
force-pushed
the
develop-v2
branch
from
61263de to
a98d800
Compare
Remove selector_inverse and is_not_wrap columns from VariableRangeCheckerAir by using a "monotonic sum" constraint approach instead of selector-based branching. This reduces trace width from 6 to 4 columns while maintaining max constraint degree of 2. Key insight: (value + two_to_max_bits) equals (row_index + 1), forming a strictly increasing sequence. By constraining this sum to increase by exactly 1 each row, combined with constraints that value can only be 0 or increment and max_bits can only stay or increment, the trace is forced into the correct enumeration. The last-row constraint acts as a checksum. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add missing imports (VerificationError, BabyBearBlake3Engine, StarkFriEngine) and remove unused dead code to allow circuit-primitives tests to compile. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tuanlinh12312
force-pushed
the
perf/revisit-varrangechecker
branch
from
1cabea1 to
d49802d
Compare
stephenh-axiom-xyz
approved these changes
Feb 11, 2026
Contributor
stephenh-axiom-xyz
left a comment
stephenh-axiom-xyz
left a comment
There was a problem hiding this comment.
A couple nits + request to change a comment, but otherwise LGTM 🚀 ! Please confirm that tests + benchmarks pass locally
- Use assert_bool for max_bits_delta constraint - Use when(next.value).assert_eq pattern instead of assert_zero(a * b) - Simplify comments and reference README for explanation - Replace "checksum" terminology with proper security explanation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves INT-5965.