perf: remove redundant Vec allocation in initialize_segment#2456
Closed
VolodymyrBg wants to merge 1 commit intoopenvm-org:mainfrom
Closed
perf: remove redundant Vec allocation in initialize_segment#2456VolodymyrBg wants to merge 1 commit intoopenvm-org:mainfrom
Vec allocation in initialize_segment#2456VolodymyrBg wants to merge 1 commit intoopenvm-org:mainfrom
Conversation
Contributor
|
Micro-optimization; not planned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
initialize_segmentallocated a newVecforaddr_space_access_counteven thoughself.addr_space_access_countwas already zeroed by the precedinglazy_update_boundary_heightscall incheck_and_segment. This caused unnecessary heap allocations on every segment initialization.Reuse the existing buffer instead of creating a new one.