feat: rv64 alu_w shift_w#2484
Draft
876pol wants to merge 15 commits intorv64-word-opcode-copy-existing-modulesfrom
Draft
feat: rv64 alu_w shift_w#2484876pol wants to merge 15 commits intorv64-word-opcode-copy-existing-modulesfrom
876pol wants to merge 15 commits intorv64-word-opcode-copy-existing-modulesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves INT-6340, INT-6343.
Summary:
base_alu_wandshift_wreuse the existing generic core AIRs (BaseAluCoreAir<RV64_WORD_NUM_LIMBS, RV64_CELL_BITS>andShiftCoreAir<RV64_WORD_NUM_LIMBS, RV64_CELL_BITS>) via type aliases, eliminating the need for duplicated core code.Rv64BaseAluWAdapter(alu_w.rs) bridges 64-bit register memory with the 4-byte core interface: it reads full 8-byte registers but only passes the low 4 bytes to the core, and sign-extends the 4-byte core output back to 8 bytes on write.