OpenCL formats: Fix many bugs in host code#5892
Merged
solardiz merged 3 commits intoopenwall:bleeding-jumbofrom Nov 16, 2025
Merged
OpenCL formats: Fix many bugs in host code#5892solardiz merged 3 commits intoopenwall:bleeding-jumbofrom
solardiz merged 3 commits intoopenwall:bleeding-jumbofrom
Conversation
Detected through testing with POCL in an ASan-enabled build. Fixes openwall#5882
Now returns 0 (fail, don't abort) during self-test/benchmark, but only after printing the error. Also document the behavior with negative return during autotune.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detected through testing with POCL in an ASan-enabled build.
Only the two Argon2 formats are still failing on all POCL, and
krb5tgs-openclis failing (but no longer crashing with ASan) on Debian 13's newer POCL (but passes test with older POCL).Fixes #5882