Warning and logging tweaks #5894
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I wasn't quite sure where to place WARN_ONCE macro. I put it in misc.h. |
magnumripper
force-pushed
the
warning-and-log-tweaks
branch
from
adc9dc5 to
de6d9d7
Compare
Member
Author
|
I will revert the |
magnumripper
force-pushed
the
warning-and-log-tweaks
branch
from
de6d9d7 to
04546d1
Compare
Member
Author
Did so now, and putc the newline to stream after the fprintf_color of the message. Also added much more (modes, formats). This PR can stay draft for a while, I'll add more of the same. |
magnumripper
force-pushed
the
warning-and-log-tweaks
branch
6 times, most recently
from
4b0a926 to
f0a5684
Compare
magnumripper
force-pushed
the
warning-and-log-tweaks
branch
2 times, most recently
from
67a894d to
08cdb1f
Compare
Add some function-like macros for log/warn/both WARN_AND_LOG() is like fprintf_color() then log_event(), with same message. WARN_ONCE() is like fprintf_color() but only once per session. LOG_ONCE() is like log_event() but only once per session. WARN_AND_LOG_ONCE() does both, with same message. Also add error color to error(), pexit() and similar stuff in misc.c
Also prefix log entries with "OpenCL:" for clarity.
magnumripper
force-pushed
the
warning-and-log-tweaks
branch
from
08cdb1f to
908a43a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds color to many warning/errors. This includes shared stuff such as BENCH_CLERROR and error() so we get more visibility to many problems.
Adds shared macros LOG_ONCE, WARN_ONCE and WARN_LOG_ONCE.
Drops obsolete dead code.