Format selection: Add an "after" option#5901
Merged
magnumripper merged 1 commit intoopenwall:bleeding-jumbofrom Nov 19, 2025
Merged
Format selection: Add an "after" option#5901magnumripper merged 1 commit intoopenwall:bleeding-jumbofrom
magnumripper merged 1 commit intoopenwall:bleeding-jumbofrom
Conversation
Matches all formats after a specific one. Put in other words, skip all formats up to and including the named one. This is for situations where you test all formats and it segfaults on eg. foo-opencl. You can now resume the tests from the next format, using --format=/foo-opencl.
solardiz
approved these changes
Nov 19, 2025
Member
solardiz
left a comment
solardiz
left a comment
There was a problem hiding this comment.
This is a welcome feature, thanks!
Those drop variables look unnecessarily complicated to me, but maybe I'm missing something.
Member
Author
Not sure if you're right or not - the logic has many moving gears because of wildcards and other things. |
Member
|
This may be worth a NEWS entry. |
Member
Author
|
Not in NEWS I think - no normal user would have a need for it anyway. But I could add it to doc/OPTIONS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches all formats after a specific one. Put in other words, skip all formats up to and including the named one.
This is for situations where you test all formats and it segfaults on eg. foo-opencl. You can now resume the tests from the next format, using --format=/foo-opencl.