Skip to content

Cracker: Bugfix for 2nd self-test that may occur in debug builds #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magnumripper merged 1 commit into from
Nov 19, 2025
+9 −5
Merged

Cracker: Bugfix for 2nd self-test that may occur in debug builds #5904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/cracker.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,15 @@ void crk_init(struct db_main *db, void (*fix_state)(void),
* or if the format has a custom reset() method (we've already called reset(db)
* from john.c, and we don't want to mess with the format's state).
*/
if (db->loaded && db->format->methods.reset == fmt_default_reset)
if ((where = fmt_self_test(db->format, db))) {
log_event("! Self test failed (%s)", where);
fprintf(stderr, "Self test failed (%s)\n", where);
error();
if (db->loaded && db->format->methods.reset == fmt_default_reset && !(options.flags & FLG_NOTESTS)) {
struct db_main *test_db = ldr_init_test_db(db->format, db);

if ((where = fmt_self_test(db->format, test_db))) {
log_event("! Self test failed (%s)", where);
fprintf(stderr, "Self test failed (%s)\n", where);
error();
}
ldr_free_db(test_db, 1);
}

#if HAVE_OPENCL
Expand Down