Skip to content

fix: recreate offer for issuance and presentation sessions#648

Open
cre8 wants to merge 2 commits intomainfrom
fix/502
Open

fix: recreate offer for issuance and presentation sessions#648
cre8 wants to merge 2 commits intomainfrom
fix/502

Conversation

@cre8
Copy link
Copy Markdown
Contributor

@cre8 cre8 commented Apr 17, 2026

Summary

Fixes #502 — the "Recreate Offer" feature was broken for issuance sessions and missing for presentation sessions.

Changes

Issuance recreate offer fix

  • Flow type mapping: OfferRequestDto stores 2 flow types (authorization_code | pre_authorized_code) but the form UI uses 3 values. prefillFromOffer() now correctly maps authorization_codeauthorization_code_external or authorization_code_iae based on the credential config's IAE actions and authorization_server field.
  • Race conditions: Refactored ngOnInit() to async with Promise.all() — all configs are loaded before prefilling. Value change subscriptions are set up after prefill to avoid interference.
  • Stepper navigation: When recreating, the stepper now jumps directly to the last step so the user can review and submit immediately.

Presentation recreate request (new)

  • canRecreateOffer() now returns true for presentation sessions that have a requestId.
  • recreateOffer() navigates to /offer/presentation with the requestId in navigation state.
  • PresentationRequestComponent picks up the prefill data and patches the form.
  • Button text dynamically shows "Recreate Offer" or "Recreate Request" depending on session type.

Files changed

  • apps/client/src/app/issuance/issuance-offer/issuance-offer.component.ts
  • apps/client/src/app/presentation/presentation-request/presentation-request.component.ts
  • apps/client/src/app/session-management/session-management-show/session-management-show.component.ts
  • apps/client/src/app/session-management/session-management-show/session-management-show.component.html

cre8 added 2 commits April 17, 2026 21:08
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
@sonarqubecloud
Copy link
Copy Markdown

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.99%. Comparing base (4a41d1d) to head (6deef26).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files         182      182           
  Lines        6568     6568           
  Branches     1591     1591           
=======================================
  Hits         3809     3809           
  Misses       2319     2319           
  Partials      440      440           
Flag Coverage Δ
e2e-test 57.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Recreate Offer feature is broken

2 participants