Conversation
|
@meghac538 Please address merge conflicts |
|
@meghac538 I'd be happy to screenshare and walk you through handling rebasing and conflict resolution, if you'd like / if it's helpful. |
Hi @dmitrizagidulin, I usually rebase using GitHub Desktop, resolving any conflicts commit by commit with the main branch. I’ve done it this way before on this project as well. |
|
@meghac538 thanks for checking -- that works fine! (re github desktop, etc) |
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
285298c to
7efc5bf
Compare
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
2e2f23d to
bed1324
Compare
|
@alexfigtree After reviewing the current branch, I’ve identified that the primary functionality suitable for inclusion in the shared library would be: validateUrl() – Core URL validation with protocol enforcement To maintain consistency with Verifier Plus, we may need to install the validator package and implement similar functionality. Recommended Approach: Since we’re already creating a shared library under verifier-plus#157, it would be ideal to include validateUrl() and isUrlSuspicious() there
|
@meghac538 Agreed, please reference this PR in other repos where work is being done |
|
@meghac538 Please reference this issue for future work related to this PR: digitalcredentials/verifier-core#24 |
Created PR for #882
PR topped over #862
The LCW now has a centralized, generalizable approach to URL validation that addresses: