Skip to content

882 spike validating urls#884

Open
meghac538 wants to merge 13 commits intomainfrom
882-spike-validating-urls
Open

882 spike validating urls#884
meghac538 wants to merge 13 commits intomainfrom
882-spike-validating-urls

Conversation

@meghac538
Copy link
Copy Markdown
Contributor

Created PR for #882

PR topped over #862

The LCW now has a centralized, generalizable approach to URL validation that addresses:

  • Correct regex patterns for valid URLs
  • Security checks for malicious/phishing URLs

@meghac538 meghac538 linked an issue Oct 17, 2025 that may be closed by this pull request
@alexfigtree
Copy link
Copy Markdown
Contributor

@meghac538 Please address merge conflicts

@dmitrizagidulin
Copy link
Copy Markdown
Contributor

@meghac538 I'd be happy to screenshare and walk you through handling rebasing and conflict resolution, if you'd like / if it's helpful.

@meghac538
Copy link
Copy Markdown
Contributor Author

@meghac538 I'd be happy to screenshare and walk you through handling rebasing and conflict resolution, if you'd like / if it's helpful.

Hi @dmitrizagidulin, I usually rebase using GitHub Desktop, resolving any conflicts commit by commit with the main branch. I’ve done it this way before on this project as well.
Just wanted to confirm if this is the right approach, or if you’d recommend handling it differently. I’d also really appreciate it if you could walk me through rebasing and conflict resolution sometime!

@dmitrizagidulin
Copy link
Copy Markdown
Contributor

@meghac538 thanks for checking -- that works fine! (re github desktop, etc)

Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
@meghac538 meghac538 force-pushed the 882-spike-validating-urls branch from 285298c to 7efc5bf Compare November 6, 2025 09:24
@meghac538 meghac538 marked this pull request as draft November 6, 2025 09:24
@meghac538 meghac538 marked this pull request as ready for review November 6, 2025 09:24
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
Signed-off-by: Megha C <megha@oneorigin.us>
@meghac538 meghac538 force-pushed the 882-spike-validating-urls branch from 2e2f23d to bed1324 Compare November 6, 2025 10:23
@meghac538
Copy link
Copy Markdown
Contributor Author

@alexfigtree After reviewing the current branch, I’ve identified that the primary functionality suitable for inclusion in the shared library would be:

validateUrl() – Core URL validation with protocol enforcement
isUrlSuspicious() – Security checks for detecting potentially malicious URLs

To maintain consistency with Verifier Plus, we may need to install the validator package and implement similar functionality.

Recommended Approach:
Bundle the validator dependency within the shared library to reduce integration complexity and ensure consistent validation behavior across both applications.

Since we’re already creating a shared library under verifier-plus#157, it would be ideal to include validateUrl() and isUrlSuspicious() there

  • This approach will:
  • Consolidate all shared utilities in one place
  • Minimize dependencies for both LCW and Verifier Plus
  • Ensure consistent URL validation and security handling
  • Simplify maintenance and future updates

@alexfigtree
Copy link
Copy Markdown
Contributor

@alexfigtree After reviewing the current branch, I’ve identified that the primary functionality suitable for inclusion in the shared library would be:

validateUrl() – Core URL validation with protocol enforcement isUrlSuspicious() – Security checks for detecting potentially malicious URLs

To maintain consistency with Verifier Plus, we may need to install the validator package and implement similar functionality.

Recommended Approach: Bundle the validator dependency within the shared library to reduce integration complexity and ensure consistent validation behavior across both applications.

Since we’re already creating a shared library under verifier-plus#157, it would be ideal to include validateUrl() and isUrlSuspicious() there

  • This approach will:
  • Consolidate all shared utilities in one place
  • Minimize dependencies for both LCW and Verifier Plus
  • Ensure consistent URL validation and security handling
  • Simplify maintenance and future updates

@meghac538 Agreed, please reference this PR in other repos where work is being done

@meghac538 meghac538 self-assigned this Nov 26, 2025
@alexfigtree
Copy link
Copy Markdown
Contributor

@meghac538 Please reference this issue for future work related to this PR: digitalcredentials/verifier-core#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SPIKE] Validating URL's

3 participants