915 cannot select profile when adding mock credential after going back one screen

[meghac538]

Created PR for #915

AC1: Swiping left should not affect ability to choose profile (navigates back to Settings screen to select profile again)
AC2: Add "go back" arrow to "Available Credentials" screen
AC3: Show credentials to add without grey text for duplicates in other profiles
AC4: Show appropriate message for credentials that exist in selected profile
AC5: Deleting a credential should update the available credentials page
AC6: Dynamic "Accept" button text

Screenshots

[alexfigtree]

AC1: Swiping left should not affect ability to choose profile (navigates back to Settings screen to select profile again) - I'm noticing that swiping left no longer moves the screen, but that's ok, we have the back arrow now, no changes requested here.

AC2: Add "go back" arrow to "Available Credentials" screen

• working

AC3: Show credentials to add without grey text for duplicates in other profiles

• working

AC4: Show appropriate message for credentials that exist in selected profile

• working

AC5: Deleting a credential should update the available credentials page

• not working: I see that removing a mock credential (1/2 GT Guides) should theoretically allow it to be added back on the Available Credentials page, but it still cannot. It may be worth differentiating between the credentials a bit more to ensure they are distinct.

AC6: Dynamic "Accept" button text

• this one is dependent on AC5 and so cannot be properly tested right now

[meghac538]

AC1: Swiping left should not affect ability to choose profile (navigates back to Settings screen to select profile again) - I'm noticing that swiping left no longer moves the screen, but that's ok, we have the back arrow now, no changes requested here.

AC2: Add "go back" arrow to "Available Credentials" screen

• working

AC3: Show credentials to add without grey text for duplicates in other profiles

• working

AC4: Show appropriate message for credentials that exist in selected profile

• working

AC5: Deleting a credential should update the available credentials page

• not working: I see that removing a mock credential (1/2 GT Guides) should theoretically allow it to be added back on the Available Credentials page, but it still cannot. It may be worth differentiating between the credentials a bit more to ensure they are distinct.

AC6: Dynamic "Accept" button text

• this one is dependent on AC5 and so cannot be properly tested right now

@alexfigtree AC3: The two mock credentials ( mockCredential and mockCredential2) in the credential.ts file are identical, they have the exact same content. When we delete one, the system still sees the other as a duplicate because they hash to the same value. Hence removing a mock credential (1/2 GT Guides) would recognise the other mock credential and hence won't allow either of them to be added as it assumes the content already present.

Solution would be to update the mockCredential2 to make it distinct from mockCredential so they will hash to different values. When we delete one credential, we should be able to add the credential from the Available Credentials page.

[kayaelle]

Will review in the future. Keep this PR open until code freeze is over.