Conversation
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Kevin <kevin.dinh@lissi.id>
JoTiTu
requested changes
Feb 19, 2025
| { | ||
| public static string ToStringWithoutTrail(this System.Uri uri) => uri.ToString().TrimEnd('/'); | ||
|
|
||
| public static Option<System.Uri> TryToParseUri(string uriString) |
| @@ -0,0 +1,15 @@ | |||
| namespace WalletFramework.Oid4Vc.Oid4Vp.Errors; | |||
|
|
|||
| public record AccessDeniedError : VpError | |||
Contributor
There was a problem hiding this comment.
- seems unused
- const can be private
Contributor
Author
There was a problem hiding this comment.
will be used by the fw consumer
| @@ -0,0 +1,15 @@ | |||
| namespace WalletFramework.Oid4Vc.Oid4Vp.Errors; | |||
|
|
|||
| public record InvalidRequestError : VpError | |||
| /// associated with the OpenID4VP Authorization Request Url and Credentials Candidates that can be used to answer the | ||
| /// request. | ||
| /// </returns> | ||
| // Task<Validation<AuthorizationRequestCandidates>> ProcessAuthorizationRequestUri( |
| /// Gets or Sets the Credential that is used to answer the input descriptor. | ||
| /// </summary> | ||
| public ICredential Credential { get; set; } = null!; | ||
|
|
|
|
||
| public record InvalidTransactionDataError : VpError | ||
| { | ||
| public const string Code = "invalid_transaction_data"; |
| try | ||
| { | ||
| return DeserializeObject<AuthorizationResponseCallback>(redirectUriJson); | ||
| Uri callback = DeserializeObject<AuthorizationResponseCallback>(redirectUriJson); |
Contributor
Author
There was a problem hiding this comment.
for implicit casting
| try | ||
| { | ||
| return DeserializeObject<AuthorizationResponseCallback>(redirectUriJson); | ||
| Uri callbackUri = DeserializeObject<AuthorizationResponseCallback>(redirectUriJson); |
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Kevin <kevin.dinh@lissi.id>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Changes proposed in this pull request:
Fixes: #