feat: implement signing for wallet attestation requests#507
Merged
Dindexx merged 1 commit intoopenwallet-foundation-labs:developfrom Feb 12, 2026
Conversation
- Add method to sign a attestation request" Signed-off-by: Kevin <kevin.dinh@lissi.id>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This PR implements the infrastructure for signing wallet attestation requests. It enables the creation of signed JWT assertions required for secure wallet attestation issuance flows within the OID4VC framework.
Changes proposed in this pull request:
Extended IAttestationSigner: Added SignWalletAttestationRequest to the abstraction layer to support signing operations.
Introduced SignedWalletAttestationRequest: Created a new record to encapsulate both the resulting JsonWebToken and the original request data.
Refactored Issuance Models:
Updated Constants: Added the AssertionJwt field key to WalletAttestationJsonFields.
Fixes: #