Skip to content

feat: implement signing for wallet attestation requests#507

Merged
Dindexx merged 1 commit intoopenwallet-foundation-labs:developfrom
lissi-id:feature/sign-wallet-walletattestation-requests
Feb 12, 2026
Merged

feat: implement signing for wallet attestation requests#507
Dindexx merged 1 commit intoopenwallet-foundation-labs:developfrom
lissi-id:feature/sign-wallet-walletattestation-requests

Conversation

@Dindexx
Copy link
Contributor

@Dindexx Dindexx commented Feb 11, 2026

Short description of what this resolves:

This PR implements the infrastructure for signing wallet attestation requests. It enables the creation of signed JWT assertions required for secure wallet attestation issuance flows within the OID4VC framework.

Changes proposed in this pull request:

  • Extended IAttestationSigner: Added SignWalletAttestationRequest to the abstraction layer to support signing operations.
    Introduced SignedWalletAttestationRequest: Created a new record to encapsulate both the resulting JsonWebToken and the original request data.

  • Refactored Issuance Models:

    • Moved WalletAttestationRequest and ConfirmationClaimJwk to a dedicated WalletAttestationRequest.cs file.
    • Renamed WalletAttestationIssuanceResponse to WalletAttestationResponse for better naming consistency.
    • Added Helper Methods: Implemented ToRequestEnvelope as an extension method to simplify the construction of the final request payload using the assertion-jwt field.
  • Updated Constants: Added the AssertionJwt field key to WalletAttestationJsonFields.

Fixes: #

- Add method to sign a attestation request"

Signed-off-by: Kevin <kevin.dinh@lissi.id>
@Dindexx Dindexx requested a review from JoTiTu February 11, 2026 15:11
@Dindexx Dindexx self-assigned this Feb 11, 2026
Copy link
Contributor

@JoTiTu JoTiTu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dindexx Dindexx merged commit 446ccee into openwallet-foundation-labs:develop Feb 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants