Fix Class import for AnonCreds Registry routes#3495
Merged
jamshale merged 8 commits intoopenwallet-foundation:mainfrom Feb 6, 2025
Merged
Fix Class import for AnonCreds Registry routes#3495jamshale merged 8 commits intoopenwallet-foundation:mainfrom
jamshale merged 8 commits intoopenwallet-foundation:mainfrom
Conversation
…ds routes Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Contributor
|
I noticed another stupid mistake here Could you fix this as part of this PR. |
Contributor
|
Actually. Forget that comment. I see that those are the same. Should be renamed but not important. |
Contributor
|
Interop tests have been a problem today. This is small enough I can merge it without them passing. |
Contributor
Author
|
@jamshale I'm not sure what a cred_rev_id is and there doesn't seem to be the equivalent for anoncreds. I'll investigate |
Contributor
|
@PatStLouis You can ignore that. It could be renamed to remove the INDY'ism but the cred_rev_id object is the same in anoncreds and indy. |
Contributor
Author
|
@jamshale there seems to be a circular import issue, I'll look into it |
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Contributor
Author
|
@jamshale I've renamed them for consistency's sake |
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
|
jamshale
approved these changes
Feb 6, 2025
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
…#3495) * Import the anoncreds revocation registry ID validator for the anoncreds routes Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Add AnonCreds Cred Rev ID values Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * rename anoncreds revocation openapi classes Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * rename anoncreds revocation openapi classes Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * update test fixtures Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Lint Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> --------- Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
…#3495) * Import the anoncreds revocation registry ID validator for the anoncreds routes Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Add AnonCreds Cred Rev ID values Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * rename anoncreds revocation openapi classes Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * rename anoncreds revocation openapi classes Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * update test fixtures Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Lint Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> --------- Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrong validator was being imported for 2 of the AnonCreds revocation management routes, validating the ID against the indy method.