Allow schema id to be used during anoncreds issuance#3497
Merged
jamshale merged 7 commits intoopenwallet-foundation:mainfrom Feb 12, 2025
Merged
Allow schema id to be used during anoncreds issuance#3497jamshale merged 7 commits intoopenwallet-foundation:mainfrom
jamshale merged 7 commits intoopenwallet-foundation:mainfrom
Conversation
ff137
requested changes
Feb 11, 2025
acapy_agent/protocols/issue_credential/v2_0/formats/anoncreds/handler.py
Outdated
Show resolved
Hide resolved
acapy_agent/protocols/issue_credential/v2_0/formats/anoncreds/handler.py
Show resolved
Hide resolved
acapy_agent/protocols/issue_credential/v2_0/formats/anoncreds/handler.py
Outdated
Show resolved
Hide resolved
acapy_agent/protocols/issue_credential/v2_0/formats/anoncreds/handler.py
Show resolved
Hide resolved
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
ff137
previously approved these changes
Feb 12, 2025
acapy_agent/protocols/issue_credential/v2_0/formats/anoncreds/handler.py
Outdated
Show resolved
Hide resolved
Signed-off-by: jamshale <jamiehalebc@gmail.com>
|
dbluhm
approved these changes
Feb 12, 2025
ff137
approved these changes
Feb 12, 2025
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
…dation#3497) * Allow schema id to be used during anoncreds issuance Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix scenario test Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix mistake in handler / Add unit tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Try a sleep in between upgrades. Issue with github actions Signed-off-by: jamshale <jamiehalebc@gmail.com> * Refactor based on PR review comments Signed-off-by: jamshale <jamiehalebc@gmail.com> * Repair _fetch_schema_attr_names function call Signed-off-by: jamshale <jamiehalebc@gmail.com> * Remove unnessecary self usage Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
…dation#3497) * Allow schema id to be used during anoncreds issuance Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix scenario test Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix mistake in handler / Add unit tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Try a sleep in between upgrades. Issue with github actions Signed-off-by: jamshale <jamiehalebc@gmail.com> * Refactor based on PR review comments Signed-off-by: jamshale <jamiehalebc@gmail.com> * Repair _fetch_schema_attr_names function call Signed-off-by: jamshale <jamiehalebc@gmail.com> * Remove unnessecary self usage Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema is needed during issuance to check whether the correct attributes were supplied. This original implementation was attempting to get the schema from local storage but the issuer does not need to be the agent that created the schema. This allows an agent to supply the
schema_idin the filter options. It will first use the registry to look it up on the data registry. If its not provided then it will attempt to get the schema from local storage and assume that it created the schema.