Skip to content

Conversation

@PatStLouis
Copy link
Contributor

When upgrading a wallet from askar to askar-anoncreds, a cred def created with a legacy did sov will return a seqNo instead of a schemaId. See #3986

This PR will resolve the schema from the seqNo and fetch the correct value.

Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see how this could cause any issues except maybe if the controller creating a presentation request is providing the seq number in the cred_def identifier of the filter.

But even then it would still map correctly to the cred def?

@jamshale
Copy link
Contributor

I am wondering what happens if the controller provides the actual schema ID for lookup instead of the seq no. Maybe there's a switcharoo that can happen before fetching the cred def as well? I think the lookup is specific for using seq no (without looking at the code)

@PatStLouis
Copy link
Contributor Author

I am wondering what happens if the controller provides the actual schema ID for lookup instead of the seq no. Maybe there's a switcharoo that can happen before fetching the cred def as well?

The controller already needs to provide the schemaId when doing a looking, providing the seqNo won't return any results.

This is about the GET /anoncreds/credential-definition/{credDefId} endpoint not returning the proper schemaId value. All other places seems to return / process the correct id value.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@jamshale jamshale merged commit 783966b into openwallet-foundation:main Jan 8, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants