Skip to content

fix: scan options in react native #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berendsliedrecht merged 3 commits into from
Jan 29, 2025
Merged

fix: scan options in react native #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd7e5e
fix: optional parameter
sairanjit Jan 28, 2025
5c73f3e
fix: scan options in react native
sairanjit Jan 29, 2025
e55bd9a
Merge branch 'openwallet-foundation:main' into fix/category-optional-…
sairanjit Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/askar-react-native/cpp/askar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,10 @@ jsi::Value storeRekey(jsi::Runtime &rt, jsi::Object options) {
State *state = new State(&cb);
state->rt = &rt;

ErrorCode code = askar_store_rekey(storeHandle,
keyMethod.length() ? keyMethod.c_str() : nullptr,
ErrorCode code = askar_store_rekey(storeHandle,
keyMethod.length() ? keyMethod.c_str() : nullptr,
passKey.c_str(), callback, CallbackId(state));

return createReturnValue(rt, code, nullptr);
}

Expand Down Expand Up @@ -350,7 +350,7 @@ jsi::Value sessionFetchAll(jsi::Runtime &rt, jsi::Object options) {
state->rt = &rt;

ErrorCode code = askar_session_fetch_all(
sessionHandle,
sessionHandle,
category.c_str(),
tagFilter.length() ? tagFilter.c_str() : nullptr,
limit,
Expand Down Expand Up @@ -518,7 +518,7 @@ jsi::Value sessionUpdateKey(jsi::Runtime &rt, jsi::Object options) {

jsi::Value scanStart(jsi::Runtime &rt, jsi::Object options) {
auto storeHandle = jsiToValue<int64_t>(rt, options, "storeHandle");
auto category = jsiToValue<std::string>(rt, options, "category");
auto category = jsiToValue<std::string>(rt, options, "category", true);

auto tagFilter = jsiToValue<std::string>(rt, options, "tagFilter", true);
auto profile = jsiToValue<std::string>(rt, options, "profile", true);
Expand All @@ -532,12 +532,12 @@ jsi::Value scanStart(jsi::Runtime &rt, jsi::Object options) {
state->rt = &rt;

ErrorCode code = askar_scan_start(
storeHandle,
storeHandle,
profile.length() ? profile.c_str() : nullptr,
category.c_str(),
category.length() ? category.c_str() : nullptr,
tagFilter.length() ? tagFilter.c_str() : nullptr,
offset,
limit,
offset,
limit,
orderBy.length() ? orderBy.c_str() : nullptr,
descending,
callbackWithResponse,
Expand Down Expand Up @@ -636,9 +636,9 @@ jsi::Value keyGenerate(jsi::Runtime &rt, jsi::Object options) {
LocalKeyHandle out;

ErrorCode code = askar_key_generate(
algorithm.c_str(),
keyBackend.length() ? keyBackend.c_str() : nullptr,
ephemeral,
algorithm.c_str(),
keyBackend.length() ? keyBackend.c_str() : nullptr,
ephemeral,
&out
);

Expand Down