Improve OpenID4VCI interoperability for mixed server behavior#1542
Open
soulkeykim wants to merge 2 commits intoopenwallet-foundation:mainfrom
Open
Improve OpenID4VCI interoperability for mixed server behavior#1542soulkeykim wants to merge 2 commits intoopenwallet-foundation:mainfrom
soulkeykim wants to merge 2 commits intoopenwallet-foundation:mainfrom
Conversation
Handle token auth metadata that advertises public clients, make DPoP optional based on server capability, accept PAR success on 200/201, reuse c_nonce from token responses, and make credential_offer parsing tolerant of URI-scheme and HTTPS forms. Test: ./gradlew :multipaz:compileKotlinJvm :multipaz:jvmTest --tests "org.multipaz.provisioning.openid4vci.OpenIDBackendUtilTest" --no-daemon Signed-off-by: Soulkey Kim <soulkey.kim@sita.aero>
soulkeykim
force-pushed
the
openid4vci-interop-fixes
branch
from
b7d11d8 to
1b10e14
Compare
Signed-off-by: Soulkey Kim <soulkey.kim@sita.aero>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves OpenID4VCI interoperability for issuer/authorization-server implementations that vary in metadata and endpoint behavior.
It is scoped to three files in
org.multipaz.provisioning.openid4vciand avoids unrelated cleanup.Fixes #1541
What changed
AuthorizationConfigurationtoken_endpoint_auth_methods_supported: ["public"]as no client authentication.supportsDPoPcapability flag.OpenID4VCIProvisioningClientsupportsDPoP.DPoP -> Bearer -> none) and retry GET when POST returns HTML.200 OKand201 Createdas successful PAR responses.c_noncefrom token responses when present.CredentialOffercredential_offerforms:openid-credential-offer:andhaip-vci:scheme normalization.https://...treated ascredential_offer_uri.Why
Several real OpenID4VCI deployments are standards-adjacent but not fully uniform.
These changes keep standards-compliant behavior intact while increasing resilience to common metadata/response variations.
Testing
./gradlew :multipaz:compileKotlinJvm :multipaz:jvmTest --tests "org.multipaz.provisioning.openid4vci.OpenIDBackendUtilTest" --no-daemon