Add mock payment SCA doctype and payment card art#1552
Open
dzuluaga wants to merge 1 commit intoopenwallet-foundation:mainfrom
Open
Add mock payment SCA doctype and payment card art#1552dzuluaga wants to merge 1 commit intoopenwallet-foundation:mainfrom
dzuluaga wants to merge 1 commit intoopenwallet-foundation:mainfrom
Conversation
…card art Adds mock Digital Payment Credential doctype (org.multipaz.payment.sca.1). Add a mock Digital Payment Credential doctype and wire it into testapp provisioning. Update payment card art used by testapp document provisioning. Refs: openwallet-foundation#1551 Test: ./gradlew :multipaz-doctypes:jvmTest --tests "org.multipaz.documenttype.TestDocumentTypeRepository.testDigitalPaymentCredentialDocumentType" Test: ./gradlew :samples:testapp:installBlueDebug Test: Manually tested on Android and iPhone (payment card visible in Document Store) Test: Video proof (iPhone): https://bit.ly/4kOLYPY Signed-off-by: Diego Zuluaga <dfzuluaga@gmail.com> Signed-off-by: Diego Zuluaga <diego@openmobilehub.org>
dzuluaga
force-pushed
the
payment-credential-dcp
branch
from
d0498b3 to
1735bc7
Compare
davidz25
reviewed
Feb 19, 2026
Contributor
davidz25
left a comment
davidz25
left a comment
There was a problem hiding this comment.
Looks good, two requests inline.
| import kotlinx.datetime.LocalDate | ||
|
|
||
| /** | ||
| * Payment SCA credential profile for card-based digital payments. |
Contributor
There was a problem hiding this comment.
Can we add a comment here saying that this currently is an example for testing in a closed ecosystem, subject to change, disclaimer disclaimer etc?
If the doctype is inspired by other documents, fair to say that too.
Contributor
There was a problem hiding this comment.
Probably should not use that logo in the bottom right...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mock Digital Payment Credential doctype (org.multipaz.payment.sca.1).
Add a mock Digital Payment Credential doctype and wire it into testapp provisioning.
Update payment card art used by testapp document provisioning.
Test: ./gradlew :multipaz-doctypes:jvmTest --tests "org.multipaz.documenttype.TestDocumentTypeRepository.testDigitalPaymentCredentialDocumentType"
Test: ./gradlew :samples:testapp:installBlueDebug
Test: Manually tested on Android and iPhone (payment card visible in Document Store)
Test: Video proof (iPhone): https://bit.ly/4kOLYPY
Fixes #1551