Draft
Conversation
…card art Adds mock Digital Payment Credential doctype (org.multipaz.payment.sca.1). Add a mock Digital Payment Credential doctype and wire it into testapp provisioning. Update payment card art used by testapp document provisioning. Refs: openwallet-foundation#1551 Test: ./gradlew :multipaz-doctypes:jvmTest --tests "org.multipaz.documenttype.TestDocumentTypeRepository.testDigitalPaymentCredentialDocumentType" Test: ./gradlew :samples:testapp:installBlueDebug Test: Manually tested on Android and iPhone (payment card visible in Document Store) Test: Video proof (iPhone): https://bit.ly/4kOLYPY Signed-off-by: Diego Zuluaga <dfzuluaga@gmail.com> Signed-off-by: Diego Zuluaga <diego@openmobilehub.org>
Signed-off-by: Diego Zuluaga <dfzuluaga@gmail.com>
dzuluaga
force-pushed
the
codex/ci-fast-test
branch
from
e5e00a9 to
8b61e9e
Compare
Contributor
|
I think this is b/c you're running into problems with our runners being too small? I already reached out to Sean at OWF about this but, yea, it's super frustrating. |
Contributor
Author
|
Thanks, David. Our team is also looking into how to optimize the unit test build task. I understand the effort is also into increasing the JVM memory, alternatively the build can skip some heavy steps in the meantime. Stay tuned. @TheBlackBit CC - @VishnuSanal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>