Add support for USB-connected NFC readers in the Multipaz library.#1561
Open
Add support for USB-connected NFC readers in the Multipaz library.#1561
Conversation
Previously this code was in Multipaz TestApp, this change moves it into the library and makes it generally available to apps, including Multipaz Identity Reader where it will be an useful feature. A new `ExternalNfcReaderStore` class is implemented which stores readers the user have previously configured. On Android in Multipaz TestApp, hook into the USB device attached intent for supported devices and use this to automatically add to the list of configured readers. Also in Multipaz TestApp, add a new "External NFC Readers" screen (which allows removing and manually granting permissions) and also use this in the "NFC sharing and scanning" and "ISO mdoc Proximity Reading" screens to allow the user to choose which NFC reader to use. See https://www.youtube.com/watch?v=KR8U-dZM6f4 for a demo. Other changes - Make available AnnotatedString.fromMarkdown() in multipaz-compose and also beef it up to support more than links. Also add unit tests. - Make available the composables for list of items and port existing users to use it. This will be useful in both Multipaz Identity Reader and Compose Wallet. Test: Unit tests. Test: Manually tested on Android. Signed-off-by: David Zeuthen <zeuthen@google.com>
Contributor
Author
|
Btw, I expect to also add support for BLE-connected NFC readers such as the ACS1555U in the near future. This is why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this code was in Multipaz TestApp, this change moves it into the library and makes it generally available to apps, including Multipaz Identity Reader where it will be an useful feature. A new
ExternalNfcReaderStoreclass is implemented which stores readers the user have previously configured.On Android in Multipaz TestApp, hook into the USB device attached intent for supported devices and use this to automatically add to the list of configured readers.
Also in Multipaz TestApp, add a new "External NFC Readers" screen (which allows removing and manually granting permissions) and also use this in the "NFC sharing and scanning" and "ISO mdoc Proximity Reading" screens to allow the user to choose which NFC reader to use.
See https://www.youtube.com/watch?v=KR8U-dZM6f4 for a demo.
Other changes
Make available AnnotatedString.fromMarkdown() in multipaz-compose and also beef it up to support more than links. Also add unit tests.
Make available the composables for list of items and port existing users to use it. This will be useful in both Multipaz Identity Reader and Compose Wallet.
Test: Unit tests.
Test: Manually tested on Android.