fix: define truncating remainder semantics in WDL 1.0 - #789
Open
claymcleod wants to merge 2 commits into
Open
Conversation
claymcleod
added
S05-in-progress
claymcleod
added
S06-voting-active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defined WDL 1.0
%as the remainder produced by truncating the exact quotient toward zero, including its behavior for negative operands and zero divisors. This resolved the ambiguity reported in #682 at the earliest affected WDL minor version.The equivalent clarification still needs to be applied to the
wdl-1.1,wdl-1.2,wdl-1.3, andwdl-1.4branches. This PR therefore references rather than closes #682 so the issue remains open until the later versions are updated.Checklist