Fix so novacomd works with new libusb-compat#1
Fix so novacomd works with new libusb-compat#1jdieter wants to merge 3 commits intoopenwebos:masterfrom
Conversation
…s to run against libusb-compat as well as the old libusb. Signed-off-by: Jonathan Dieter <jdieter@lesbg.com>
Signed-off-by: Jonathan Dieter <jdieter@lesbg.com>
Signed-off-by: Jonathan Dieter <jdieter@lesbg.com>
|
I just tested this with libusb-compat on Fedora, works great. Thanks for being awesome, Jonathon :) |
|
Thanks, I'm getting this reviewed for Fedora at https://bugzilla.redhat.com/show_bug.cgi?id=809114 and https://bugzilla.redhat.com/show_bug.cgi?id=809116. |
|
Is Mohamed still actively reviewing those packages? I'd love to help you get them in to fedora (I'm sponsored, as well, and was testing your patches to build an RPM locally ;) ) |
|
Sorry for the delay, but, yes, Mohamed finished reviewing the packages and novacom and novacomd are both available in the Fedora and EPEL repositories (currently updates-testing for F15+ and EL5+). To install both (the common use-case), just install novacom using yum. |
|
That's awesome. Now if only @openwebos would review your patches :( |
|
Hang in there guys - we're getting ready to start pulling in changes. We appreciate your patience! |
|
jonathon, If you would like us to consider integrating this pull request, could I ask you to please add a DCO to our commit message and resubmit. See https://github.com/openwebos/build-desktop/wiki/How%20we%20accept%20contributions and the pages it links to for instructions. Congratulations, by the way, it looks like your changes got into Fedora, or am I misreading the bug reports you link to? |
|
Any update on getting these merged? |
|
The original submitter needs to send it up with the DCO. |
Use usb-bulk-[read|write] instead of homemade handlers. This allows us to
run against libusb-compat as well as the old libusb.
Signed-off-by: Jonathan Dieter jdieter@lesbg.com