Skip to content

Add message to PG critic output if no issues are found. #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex-Jordan merged 1 commit into from
Jan 3, 2026
+7 −4
Merged

Add message to PG critic output if no issues are found. #2876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions templates/ContentGenerator/Instructor/PGProblemEditor/pg_critic.html.ep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
%
<div class="m-3 overflow-auto">
<h2><%= maketext('PG Critic Violations') %></h2>
% my @pgCriticViolations = grep { $_->policy =~ /^Perl::Critic::Policy::PG::/ } @$violations;
% my @pgCriticViolations = grep { $_->policy =~ /^Perl::Critic::Policy::PG::/ } @$violations;
% my @perlCriticViolations = grep { $_->policy !~ /^Perl::Critic::Policy::PG::/ } @$violations;
% unless (@pgCriticViolations || @perlCriticViolations) {
<p><%= maketext('Congratulations! No PG critic violations found.') %></p>
% }
% if (@pgCriticViolations) {
<h3 class="mt-2"><%= maketext('The following PG issues should be fixed:') %></h3>
<ul class="list-group">
Expand Down Expand Up @@ -35,8 +39,7 @@
</li>
% }
</ul>
%}
% my @perlCriticViolations = grep { $_->policy !~ /^Perl::Critic::Policy::PG::/ } @$violations;
% }
% if (@perlCriticViolations) {
<h3 class="mt-2"><%= maketext('The following general Perl issues should be fixed:') %></h3>
<ul class="list-group">
Expand All @@ -52,5 +55,5 @@
</li>
% }
</ul>
%}
% }
</div>