Skip to content

[examples] Added UI guidance to JSONDataUpdate append example#495

Closed
Adityashandilya555 wants to merge 3 commits intoopenwisp:masterfrom
Adityashandilya555:add-ui-guidance-append-example
Closed

[examples] Added UI guidance to JSONDataUpdate append example#495
Adityashandilya555 wants to merge 3 commits intoopenwisp:masterfrom
Adityashandilya555:add-ui-guidance-append-example

Conversation

@Adityashandilya555
Copy link
Contributor

Summary

  • Added an info banner to the netjsonmap-appendData.html example explaining its purpose
  • The banner describes that this example demonstrates appending new data to existing map data based on zoom level
  • Users are instructed to zoom in to level 4 to see additional nodes being added

Related Issue

#492

Test plan

  • Open the JSONDataUpdate append example
  • Verify the info banner is displayed at the top of the page
  • Verify the banner text clearly explains the example's purpose
  • Zoom in to level 4 to confirm additional nodes are appended

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

Adds a fixed-position information banner (#info-banner) and accompanying CSS to normalize full-viewport layout, plus a new map container element in the netjsonmap-appendData.html example. Updates the NetJSONGraph initialization to attach the map to the new container via the el option. Changes are presentational and wiring only; no data-processing or behavior logic was introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required sections from the template including the checklist items, contributor guidelines acknowledgment, and test cases confirmation. While it includes summary and related issue reference, it is incomplete against the repository's template. Add the required checklist items (read guidelines, manual testing, test cases, documentation updates) to match the repository's description template structure.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding UI guidance (info banner) to the JSONDataUpdate append example, which aligns perfectly with the raw summary and PR objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da5bd6e and 14ae9b9.

📒 Files selected for processing (1)
  • public/example_templates/netjsonmap-appendData.html
🚧 Files skipped from review as they are similar to previous changes (1)
  • public/example_templates/netjsonmap-appendData.html
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Tests and Coverage

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 23, 2026
@Adityashandilya555 Adityashandilya555 force-pushed the add-ui-guidance-append-example branch from da5bd6e to 469f8ff Compare January 23, 2026 17:42
…p#492

Added an info banner to the netjsonmap-appendData.html example
explaining that it demonstrates appending new data to existing
map data based on zoom level, and instructing users to zoom in
to level 4 to see additional nodes being added.

Related to openwisp#492
@Adityashandilya555 Adityashandilya555 force-pushed the add-ui-guidance-append-example branch from 469f8ff to c83f34c Compare January 23, 2026 17:47
@Adityashandilya555 Adityashandilya555 force-pushed the add-ui-guidance-append-example branch from 9809716 to 14ae9b9 Compare January 24, 2026 02:35
@Adityashandilya555
Copy link
Contributor Author

Netjsongraph.js_.Examples.2.mp4

@Adityashandilya555
Copy link
Contributor Author

closed this pr in support of this ->#498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant