Skip to content

[fix] delay stop until configuration is applied #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viscous106 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fix] delay stop until configuration is applied #248

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c58683e
[fix] Delay stop until configuration is applied #172
Viscous106 Feb 27, 2026
2928657
Merge branch 'master' into 172-bugFix
Viscous106 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions openwisp-config/files/openwisp.init
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,21 +82,27 @@ service_triggers() {
procd_add_reload_trigger openwisp
}

stop_service() {
logger -s "$PROG_NAME stopping" -t openwisp -p daemon.info
}

reload_service() {
logger -s "$PROG_NAME received reload trigger" -t openwisp -p daemon.info
# avoid reloading while configuration is being applied
wait_applying_config() {
# avoid stopping/reloading while configuration is being applied
# will wait for a maximum of 30 seconds
for _ in $(seq 1 30); do
if [ -f "$CONTROL_FILE" ]; then
sleep 1
else
break
return 0
fi
done
# timed out: remove stale marker so we can proceed
rm -f "$CONTROL_FILE"
}

stop_service() {
logger -s "$PROG_NAME stopping" -t openwisp -p daemon.info
wait_applying_config
}

reload_service() {
logger -s "$PROG_NAME received reload trigger" -t openwisp -p daemon.info
wait_applying_config
start
}