[tests] Import django_loci selenium tests, fix failing readonly tests #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported selenium test cases for device admin from `django_loci`. The readonly tests were failing due to user not belonging to the same organization of instances. Signed-off-by: DragnEmperor <[email protected]>
codesankalp
requested changes
Apr 13, 2025
Member
codesankalp
left a comment
codesankalp
left a comment
There was a problem hiding this comment.
@DragnEmperor I approved the tests workflow, but they’re still failing. If the failures are due to a dependency on your django-loci branch, please add a tarball link to your branch in requirements.txt to ensure the tests pass.
Once the django-loci PR is merged, you can revert the requirements.txt change in this PR.
2 tasks
DragnEmperor
force-pushed
the
tests/failing-readonly-tests
branch
from
4203d89 to
dadf6c7
Compare
The geo selenium tests were failing overall due to organization not being created for the device. Added organization mixin to solve this. Also added a temporary link to `django_loci` tarball in requirements.txt to tackle failing builds. Signed-off-by: DragnEmperor <[email protected]>
DragnEmperor
force-pushed
the
tests/failing-readonly-tests
branch
from
dadf6c7 to
643525a
Compare
nemesifier
reviewed
Apr 24, 2025
nemesifier
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported selenium test cases for device admin from
django_loci. The readonly tests were failing due to user not belonging to the same organization of instances.Checklist
Description of Changes
Imported selenium test cases for device admin from
django_loci.The readonly tests were failing due to user not belonging to the same organization of instances.