Skip to content

[fix] Fixed unsaved changes alert for readonly map #560 #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemesifier merged 4 commits into from
May 2, 2025
Merged

[fix] Fixed unsaved changes alert for readonly map #560 #1014

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9961e59
[fix] Fixed unsaved changes alert for readonly map #560
DragnEmperor Apr 26, 2025
c85202e
[tests] Add test for unsaved changes alert
DragnEmperor Apr 30, 2025
6c66791
[chores] Update openwisp_controller/geo/tests/test_selenium.py
nemesifier May 2, 2025
f2ce2fe
Merge branch 'master' into issues/560-readonly-map
nemesifier May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions openwisp_controller/config/static/config/js/unsaved_changes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"config-0-config",
"config-0-context",
"devicelocation-0-geometry",
"geometry",
];
// ignore fields that have no name attribute, begin with "_" or "initial-"
if (
Expand Down
4 changes: 4 additions & 0 deletions openwisp_controller/geo/tests/test_selenium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ class TestDeviceAdminSelenium(
def _get_prefix(cls):
return cls.inline_field_prefix

# set timeout to 5 seconds to allow enough time for presence of elements
def wait_for_presence(self, by, value, timeout=5, driver=None):
return super().wait_for_presence(by, value, timeout, driver)

def _fill_device_form(self):
org = self._get_org()
self.find_element(by=By.NAME, value='mac_address').send_keys(
Expand Down
Loading