[tests] Added multi-tentant tests for shared objects #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To do (general)
in OpenWISP Contributor's Board
pandafy
force-pushed
the
updated-multitenant-tests
branch
2 times, most recently
from
3bcabf0 to
2d4afea
Compare
pandafy
commented
May 27, 2025
.github/workflows/ci.yml
Outdated
| @@ -75,6 +75,7 @@ jobs: | |||
| pip install -U pip wheel setuptools | |||
| pip install -U -r requirements-test.txt | |||
| pip install -U -e . | |||
| pip install -UI "openwisp-users @ https://github.com/openwisp/openwisp-users/tarball/issues/238-view-shared-objects" | |||
There was a problem hiding this comment.
TODO: Remove before merging
nemesifier
requested changes
May 27, 2025
There was a problem hiding this comment.
I tried accessing shared objects via REST API and this is what I found:
- Ok:
- Device, Vpn, Credential, IPAM subnet
- Not ok:
- Template: 403
- Ca: 403
- Cert: 403
- Ip address list of a shared subnet, I get 404, eg:
/api/v1/ipam/subnet/{pkl}/ip-address/
When using the admin it becomes evident that we'll need to work on #848 next.
4 tasks
pandafy
force-pushed
the
updated-multitenant-tests
branch
from
2d4afea to
73bc66f
Compare
pandafy
force-pushed
the
updated-multitenant-tests
branch
2 times, most recently
from
46c0821 to
c46269f
Compare
pandafy
commented
Jun 4, 2025
| @@ -76,6 +76,7 @@ jobs: | |||
| pip install -U pip wheel setuptools | |||
| pip install -U -r requirements-test.txt | |||
| pip install -U -e . | |||
| pip install -UI "openwisp-users @ https://github.com/openwisp/openwisp-users/tarball/issues/238-view-shared-objects" "cryptography~=43.0.3" | |||
There was a problem hiding this comment.
Upgrading openwisp-users was installing the latest version of cryptography which is incompatible with django-x509. Thus, pinning the dependency here fixed the CI build.
Added migrations to add "view" permissions
pandafy
force-pushed
the
updated-multitenant-tests
branch
from
c46269f to
2a4a863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Blockers